Yiyiyimu commented on a change in pull request #165:
URL: https://github.com/apache/apisix-docker/pull/165#discussion_r631340887
##########
File path: .github/workflows/apisix_push_docker_hub.yaml
##########
@@ -14,11 +14,30 @@ jobs:
steps:
- name: Check out the repo
uses: actions/checkout@v2
+ with:
+ submodules: recursive
+ # Setup Buildx builder
+ - name: Setup Docker Buildx
+ uses: ./.github/actions/setup-buildx-action
+
+ # Login
- name: Login
- run: echo ${{ secrets.DOCKER_PASSWORD }} | docker login --username=${{
secrets.DOCKER_USERNAME }} --password-stdin
+ uses: ./.github/actions/login-action
+ with:
+ username: ${{ secrets.DOCKER_USERNAME }}
+ password: ${{ secrets.DOCKER_PASSWORD }}
+
+ # For docker multi arch build
+ - name: Setup QEMU
+ uses: ./.github/actions/setup-qemu-action
- - name: Push apisix image to Docker Hub
- run:
- make build-on-${{ matrix.platform }}
- make push-on-${{ matrix.platform }}
+ - name: Build and push
+ id: docker_build
+ uses: ./.github/actions/build-push-action
+ with:
+ context: .
+ file: ./${{ matrix.platform }}/Dockerfile
+ platforms: linux/amd64,linux/arm64
Review comment:
Why do we need another amd64 image here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
