spacewander commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r692638807
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -459,11 +459,11 @@ http {
server {
{% for _, item in ipairs(node_listen) do %}
- listen {* item.port *} default_server {% if enable_reuseport then %}
reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
- {% end %}
- {% if ssl.enable then %}
+ listen {* item.ip *}:{* item.port *} default_server {% if
enable_reuseport then %} reuseport {% end %} {% if item.enable_http2 then %}
http2 {% end %};
+ {% if item.allow_ssl and ssl.enable then %}
Review comment:
Agree. Personally, I prefer to use a new key "listen" since it is not
just with port. Maybe we need to move "enable_http2" under "listen" too. Like
this one:
```
apisix:
ssl:
# enable_http2: false
# listen_port: ...
listen:
- ip: 127.0.0.1
port: 9443
enable_http2: true # per listen configuration
```
@wayne-cheng
What's your opinion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
