wayne-cheng commented on a change in pull request #4856:
URL: https://github.com/apache/apisix/pull/4856#discussion_r692649624
##########
File path: apisix/cli/ngx_tpl.lua
##########
@@ -459,11 +459,11 @@ http {
server {
{% for _, item in ipairs(node_listen) do %}
- listen {* item.port *} default_server {% if enable_reuseport then %}
reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
- {% end %}
- {% if ssl.enable then %}
+ listen {* item.ip *}:{* item.port *} default_server {% if
enable_reuseport then %} reuseport {% end %} {% if item.enable_http2 then %}
http2 {% end %};
+ {% if item.allow_ssl and ssl.enable then %}
Review comment:
@spacewander
I cannot agree any more. BTW, do I need to consider compatibility with the
old configuration about ssl? There are something troublesome to deal with, the
new config need to be merged with the old config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
