spacewander commented on a change in pull request #4881:
URL: https://github.com/apache/apisix/pull/4881#discussion_r694610416
##########
File path: t/cli/test_validate_config.sh
##########
@@ -69,3 +69,23 @@ fi
make stop
echo "passed: allow configuring address in stream_proxy"
+
+sed -i 's/^ \(node_listen:\)/ #\1/g' conf/config-default.yaml
+sed -i 's/^ \(- 9080\)/ #\1/g' conf/config-default.yaml
+sed -i 's/^ # \(node_listen: 9080\)/ \1/g' conf/config-default.yaml
+
+echo '
+apisix:
+ node_listen:
Review comment:
Could we keep the table in conf/config-default.yaml and use number in
config.yaml? Better to avoid touching config-default.yaml in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
