wayne-cheng commented on a change in pull request #4881:
URL: https://github.com/apache/apisix/pull/4881#discussion_r694641936
##########
File path: t/cli/test_validate_config.sh
##########
@@ -69,3 +69,23 @@ fi
make stop
echo "passed: allow configuring address in stream_proxy"
+
+sed -i 's/^ \(node_listen:\)/ #\1/g' conf/config-default.yaml
+sed -i 's/^ \(- 9080\)/ #\1/g' conf/config-default.yaml
+sed -i 's/^ # \(node_listen: 9080\)/ \1/g' conf/config-default.yaml
+
+echo '
+apisix:
+ node_listen:
Review comment:
The previous existing test cases which use number in `config.yaml` have
achieved this goal you said.
Take an example from the file `t/cli/test_main.sh`:
```shell
echo "
apisix:
node_listen:
- 9080
- 9081
- 9082
ssl:
listen_port:
- 9443
- 9444
- 9445
" > conf/config.yaml
make init
```
This test that I added in `t/cli/test_validate_config.sh` is used to test
the case that the `config-default.yaml` use number. In fact, the
`config-default.yaml` hasn’t changed because the test case exec `git chekout
conf/config-default.yaml` in the end.
What do you think? @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
