tokers commented on a change in pull request #726:
URL:
https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r737942838
##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -126,6 +126,14 @@ type ApisixUpstreamConfig struct {
// service versions.
// +optional
Subsets []ApisixUpstreamSubset `json:"subsets,omitempty"
yaml:"subsets,omitempty"`
+
+ // The host option sent to the upstream, value can be pass, node and
rewrite.
Review comment:
I'm afraid the `node` type is meaningless in the scenario. Since we
either use the ClusterIP or the pod IPs, and even for ExternalName type
service, we have just one "node", so actually only `pass` and `rewrite` are
required.
Also, `pass` and `rewrite` are not so semantic, I prefer to use some more
descriptive terms here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
