tokers commented on a change in pull request #726:
URL: 
https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r747143769



##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` 
scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer 
configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but 
is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy

Review comment:
       Add an empty line after this title.

##########
File path: docs/en/latest/concepts/apisix_upstream.md
##########
@@ -193,3 +193,33 @@ In the meanwhile, the ApisixUpstream `foo` sets `http` 
scheme for port `7000` an
 (all ports are the service port). But both ports shares the load balancer 
configuration.
 
 `PortLevelSettings` is not mandatory if the service only exposes one port but 
is useful when multiple ports are defined.
+
+### Http Host Rewrite Policy
+This is mainly used for external service outside the Kubernetes cluster, you 
can configure different host rewrite policies when the request is sent to the 
upstream.
+Here's an example of kubernetes service used in the test case.
+```
+kind: Service
+apiVersion: v1
+metadata:
+  name: foo-service
+spec:
+  type: ExternalName
+  externalName: foo.com
+  ports:
+  - name: http
+    port: 80
+    protocol: TCP
+    targetPort: 80
+```
+The following configuration configures `useRewriteTo` rewrite policy to change 
the host option to `foo.org`.
+```
+apiVersion: apisix.apache.org/v1
+kind: ApisixUpstream
+metadata:
+  name: foo-service
+spec:
+  httpHostRewritePolicy:

Review comment:
       The specification is bad. You should split them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to