tokers commented on a change in pull request #726:
URL:
https://github.com/apache/apisix-ingress-controller/pull/726#discussion_r747925062
##########
File path: pkg/kube/apisix/apis/config/v1/types.go
##########
@@ -23,6 +23,15 @@ import (
"github.com/apache/apisix-ingress-controller/pkg/kube/apisix/apis/config/v2alpha1"
)
+const (
+ // UseOriginalClientHost means host option set to "pass" for the
upstream
+ UseOriginalClientHost = "useOriginalClientHost"
Review comment:
As per the Kubernetes convention, the value should be in upper camel
case. Like values of `ImagePullPolicy`: `Always`, `Never`, `IfNotPresent`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
