kwanhur commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r813580415
##########
File path: .github/workflows/code-lint.yml
##########
@@ -28,3 +28,20 @@ jobs:
. ./ci/common.sh
export_or_prefix
make lint
+
+ sc-lint:
+ runs-on: ubuntu-latest
+ timeout-minutes: 5
+ steps:
+ - name: Checkout code
+ uses: actions/[email protected]
+ with:
+ submodules: true
+
+ - name: Shellcheck code
+ run: |
+ scversion="latest"
+ wget -O-
"https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz";
| tar -xJv
+ cp -av "shellcheck-${scversion}/shellcheck" /usr/local/bin/
Review comment:
This way is ok to install `shellcheck`, but I'm not sure its repository
updates to latest version.
1. latest version may add new check rules and it covers the before.
2. different developers use different version, the latest covers them.
The package must uniformly install from repo unless no supported, I'll
improve installation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
