kwanhur commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r815545202
##########
File path: ci/common.sh
##########
@@ -15,6 +15,8 @@
# limitations under the License.
#
+# shellcheck disable=SC2148
Review comment:
SC2148(Add a shebang) rule has enabled, remove it `ci code-lint` will
run failed.
The key point is that, all the scripts have the shebang but `ci/common.sh`
and `t/cli/common.sh`.
`disable` in script file, just scope the file, no influences on the other.
To fix the check failure, three solutions to choose:
1. enable SC2148 and add shellcheck disable declaration(just like now), test
case
[SC2148](https://github.com/kwanhur/apisix/runs/5301576428?check_suite_focus=true).
2. enable SC2148 and add a shebang in `common.sh`, but it seems not so
suitable, like https://github.com/apache/apisix/pull/6340#discussion_r809653666.
3. disable SC2148, this will not find it when add a script without shebang.
Summary, solution 1 could be the better.
Hope your voice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
