spacewander commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r815566024
##########
File path: ci/common.sh
##########
@@ -15,6 +15,8 @@
# limitations under the License.
#
+# shellcheck disable=SC2148
Review comment:
Sure, but why use
> enable=SC2148
in
https://github.com/apache/apisix/pull/6428/files#diff-c71502ae2fb6ee770263dbf93031c6bb1549ef6b2970b862daf24d01a1ded277R22?
Could we keep it disabled? Look like the check is enabled by you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
