spacewander commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r818244525
##########
File path: .github/workflows/code-lint.yml
##########
@@ -28,3 +28,18 @@ jobs:
. ./ci/common.sh
export_or_prefix
make lint
+
+ sc-lint:
+ runs-on: ubuntu-latest
+ timeout-minutes: 5
+ steps:
+ - name: Checkout code
+ uses: actions/[email protected]
+
+ - name: Shellcheck code
+ run: |
+ scversion="latest"
+ wget -O-
"https://github.com/koalaman/shellcheck/releases/download/${scversion?}/shellcheck-${scversion?}.linux.x86_64.tar.xz";
| tar -xJv
+ cp -av "shellcheck-${scversion}/shellcheck" /usr/local/bin/
+ shellcheck --version
+ shellcheck benchmark/*.sh bin/apisix ci/*.sh
ci/pod/nacos/healthcheck/*.sh t/cli/*.sh t/plugin/grpc-web/*.sh utils/*.sh
Review comment:
Would be better to use `git ls-files | grep "\.sh$" | xargs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
