tao12345666333 commented on code in PR #1141:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1141#discussion_r917515042
##########
pkg/config/config.go:
##########
@@ -67,6 +67,8 @@ const (
ControllerName = "apisix.apache.org/gateway-controller"
)
+type ApisxiVersion string
+
Review Comment:
ditto
##########
conf/config-default.yaml:
##########
@@ -77,6 +77,7 @@ kubernetes:
# Note: This feature is currently under
development and may not work as expected.
# It is not recommended to use it in a
production environment.
# Before we announce support for it to
reach Beta level or GA.
+ apisix_version: apisix.apache.org/v2beta3 #the api group version default
"apisix.apache.org/v2beta3", can be "apisix.apache.org/v2beta3" or
"apisix.apache.org/v2"
Review Comment:
I think it would be better to name it api_version or cr_api_version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
