tao12345666333 commented on code in PR #1141:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1141#discussion_r917696874
##########
cmd/ingress/ingress.go:
##########
@@ -166,6 +166,7 @@ For example, no available LB exists in the bare metal
environment.`)
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixTlsVersion,
"apisix-tls-version", config.ApisixV2beta3, "the supported apisixtls api group
version, can be \"apisix.apache.org/v2beta3\" or \"apisix.apache.org/v2\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixClusterConfigVersion,
"apisix-cluster-config-version", config.ApisixV2beta3, "the supported
ApisixClusterConfig api group version, can be \"apisix.apache.org/v2beta3\" or
\"apisix.apache.org/v2\"")
cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApisixConsumerVersion,
"apisix-consumer-version", config.ApisixV2beta3, "the supported ApisixConsumer
api group version, can be \"apisix.apache.org/v2beta3\" or
\"apisix.apache.org/v2\"")
+ cmd.PersistentFlags().StringVar(&cfg.Kubernetes.ApiVersion,
"api-version", config.DefaultApisixVersion, config.ApisixVersionDescribe)
Review Comment:
Can you replace these `ApisixVersion` with `APIVersion`?
We don’t need keep the name `config.ApisixVersion`
`config.DefaultApisixVersion` etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
