tao12345666333 commented on code in PR #1141:
URL:
https://github.com/apache/apisix-ingress-controller/pull/1141#discussion_r917750938
##########
pkg/config/config.go:
##########
@@ -99,6 +104,7 @@ type KubernetesConfig struct {
ApisixConsumerVersion string
`json:"apisix_consumer_version" yaml:"apisix_consumer_version"`
ApisixTlsVersion string
`json:"apisix_tls_version" yaml:"apisix_tls_version"`
ApisixClusterConfigVersion string
`json:"apisix_cluster_config_version" yaml:"apisix_cluster_config_version"`
+ ApiVersion string `json:"api_version"
yaml:"api_version"`
Review Comment:
I suggest change it to `APIVersion`
##########
pkg/config/config.go:
##########
@@ -57,8 +57,8 @@ const (
ApisixV2beta3 = "apisix.apache.org/v2beta3"
// ApisixV2 represents apisix.apache.org/v2
ApisixV2 = "apisix.apache.org/v2"
- // DefaultApisixVersion refers to the default resource version
- DefaultApisixVersion = ApisixV2beta3
+ // DefaultApiVersion refers to the default resource version
Review Comment:
```suggestion
// DefaultAPIVersion refers to the default resource version
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
