Ian Maxon has posted comments on this change. Change subject: Files necessary for initial perf regression tests ......................................................................
Patch Set 7: (4 comments) I figure it's kind of part of the test itself, so it makes it easier in any case. The alternative would be to leave them on the filesystem and copy them over each time. https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java: Line 71: if(aqlFilePath.toFile().isDirectory()){ > The formatting looks strange here. Hm, how so? Lack of spaces between closing paren and bracket? https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java: Line 29: import org.apache.asterix.experiment.builder.*; > Could we undo this? Oh, whoops, yeah. IntelliJ just did it automatically. https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp: Line 1: use experiments; > Do we need license headers here? Can we add them? I mean, I guess I can add them. Are SQL++ comments the same as AQL ones? https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml: Line 1: <!-- > UC license header. Whoops! Nice catch. -- To view, visit https://asterix-gerrit.ics.uci.edu/884 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21e2d44ca46a4a28478d9ef256c4fa8d53f03dc9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
