Till Westmann has posted comments on this change. Change subject: Files necessary for initial perf regression tests ......................................................................
Patch Set 7: (2 comments) Ok, I guess that's not really a secret :) https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java: Line 71: if(aqlFilePath.toFile().isDirectory()){ > Hm, how so? Lack of spaces between closing paren and bracket? Yep, doesn't look like our formatter ran over this one. https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp: Line 1: use experiments; > I mean, I guess I can add them. Are SQL++ comments the same as AQL ones? Yep. -- To view, visit https://asterix-gerrit.ics.uci.edu/884 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21e2d44ca46a4a28478d9ef256c4fa8d53f03dc9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Young-Seok Kim <kiss...@gmail.com> Gerrit-HasComments: Yes
