Young-Seok Kim has posted comments on this change. Change subject: Files necessary for initial perf regression tests ......................................................................
Patch Set 7: (2 comments) It will be good to have a high-level document which explains what perf regression tests are, what the purpose of the tests is, and what kind of queries are executed in the tests. There are minor comments. Please address them. https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractPerfLoadBuilder.java File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/builder/AbstractPerfLoadBuilder.java: Line 172: lsAction.add(new AbstractRemoteExecutableAction(ncHost, username, sshKeyLocation) { lsAction seems useless. Line 194: //load data into pidx The comment should be something like a "//send SQLPP query" -- To view, visit https://asterix-gerrit.ics.uci.edu/884 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21e2d44ca46a4a28478d9ef256c4fa8d53f03dc9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Young-Seok Kim <[email protected]> Gerrit-HasComments: Yes
