Till Westmann has posted comments on this change.

Change subject: Add init parameter option for external functions.
......................................................................


Patch Set 3:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1006/3//COMMIT_MSG
Commit Message:

Line 7: Add init parameter option for external functions.
What can we use this for?


https://asterix-gerrit.ics.uci.edu/#/c/1006/3/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java:

Line 1799:             // for cfs, assign null to init_para for now.
Looks like this should be the empty string and not null.


https://asterix-gerrit.ics.uci.edu/#/c/1006/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java
File 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entitytupletranslators/FunctionTupleTranslator.java:

Line 40: import org.apache.hadoop.hive.ql.io.orc.Metadata;
Why do we need this import?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1006
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to