Xikui Wang has posted comments on this change. Change subject: Add init parameter option for external functions. ......................................................................
Patch Set 6: @Till & Michael, There are many comments from SonaQube that regarding to the existed coding style problems. Should I try to resolve that in my patch? How about the parameter number one, the one in AsterixExternalScalarFunctionInfo.java. btw, in case I am using tools in a wrong and wasting resources on the server due to my lack of experience. I am following the 'Introduction to the Build Lifecycle ' on Maven and trying to minimize the submit to Jenkins (I assume that's the goal?). I executed 'mvn test' on my local machine for unit tests and then ran 'mvn verify' based on the procedure. 'mvn test' costs ~40mins, which is acceptable. 'mvn verify' takes absurdly long time, and get stuck on certain cases (just keep waiting on something). So I guess the right procedure will be 'mvn test' locally and then 'gerrit submit' to check integration test result on jenkins? Thanks ahead. :) -- To view, visit https://asterix-gerrit.ics.uci.edu/1006 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <xkk...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: No
