Michael Blow has posted comments on this change. Change subject: Add init parameter option for external functions. ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1006/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/AsterixExternalScalarFunctionInfo.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/functions/AsterixExternalScalarFunctionInfo.java: Line 34: String body, String language, List<IAType> argumentTypes,String initParas, IResultTypeComputer rtc) { initParas->initParams? missing space after argumentTypes, Line 36: initParas); this probably fits on the previous line within 120 chars... https://asterix-gerrit.ics.uci.edu/#/c/1006/3/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixExternalFunctionInfo.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixExternalFunctionInfo.java: Line 52: String initParas) { paras->params -- To view, visit https://asterix-gerrit.ics.uci.edu/1006 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I437880a700f61440ffab9f44035798e538fb9ff5 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
