Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1701: Fix log file boundry check ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1306/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 160: // Make sure the log will not exceed the log file size > Why's it true that appendPage.hasSpace may be false, but the inner file siz To be clearer, I mean in what scenario will getLogFileOffset + logSize always be less than logFileSize? This is what's not clear to me; I don't quite see how the order of the checks being reversed would lead to the log file potentially never being changed. Shouldn't this always get hit regardless of the page size, since it's based on offsets? -- To view, visit https://asterix-gerrit.ics.uci.edu/1306 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I538a8b931f3d50a00b092f218887a9731d14e235 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
