Ian Maxon has posted comments on this change. Change subject: ASTERIXDB-1701: Fix log file boundry check ......................................................................
Patch Set 1: Code-Review+2 (1 comment) It looks fine to me, but I think Mike B should still have a look even though I'm +2ing. https://asterix-gerrit.ics.uci.edu/#/c/1306/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 160: // Make sure the log will not exceed the log file size > Not necessarily. Aha, I understand now. Not only is it that the last page can overhang, but the calculation of that is done in such a way that you wouldn't know if it had gone far enough over. Subtle! A very good catch. -- To view, visit https://asterix-gerrit.ics.uci.edu/1306 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I538a8b931f3d50a00b092f218887a9731d14e235 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
