Michael Blow has posted comments on this change. Change subject: ASTERIXDB-1701: Fix log file boundry check ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1306/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java: Line 160: // Make sure the log will not exceed the log file size +1- I'm confused as well, as to how we ever would have an appendPage whose capacity exceeds a log file boundary, unless we had a single log record whose size exceeds a log file size. That currently is not handled. -- To view, visit https://asterix-gerrit.ics.uci.edu/1306 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I538a8b931f3d50a00b092f218887a9731d14e235 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
