abdullah alamoudi has posted comments on this change. Change subject: Remove ICCContext ......................................................................
Patch Set 2: The motivation is to get rid of yet another confusing context. The ICCContext is just a wrapper for cluster topology (which I think should go away since it is unused right now but Till and Yingyi think otherwise). In fact, the cluster topology is just a wrapper around NetworkSwitch. why don't we use network switch directly? I have no idea. In addition, this change gets rid of a confusing way of getting the ip-nodes mapping. with the context, it creates a work and put it in the work queue, once it is time to execute, it will simply fill the map with the mapping at the cluster controller service. In the new patch, I got rid of the casting by introducing an interface for ClusterControllerService which to me is much better than having the confusing ICCContext. -- To view, visit https://asterix-gerrit.ics.uci.edu/1322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
