abdullah alamoudi has posted comments on this change. Change subject: Remove ICCContext ......................................................................
Patch Set 4: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1322/4/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/RuntimeUtils.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/util/RuntimeUtils.java: Line 58: map.putAll(((ClusterControllerService) AsterixAppContextInfo.INSTANCE.getCCApplicationContext() > Still cast here. Done https://asterix-gerrit.ics.uci.edu/#/c/1322/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IClusterControllerService.java: Line 39: Map<InetAddress, Set<String>> getIpAddressNodeNameMap(); > Why do we need this new interface? This interface is to avoid the casting. 1) These methods are already in ClusterControllerService. it is not getting bigger than it is. In fact, it is getting smaller. What makes it big, is the ICCContext inner implementation in there. 2) This change in no way enable the user to do anything they couldn't do before. Again, it is only here to get rid of the cast and IMO, we need two different interfaces for ClusterControllerService and NodeControllerService since they are both fundamentally different and we need to avoid castings. https://asterix-gerrit.ics.uci.edu/#/c/1322/4/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/ClusterControllerService.java: Line 357: return ipAddressNodeNameMap; > How do you handle dynamic cluster membership now? whenever register node is called, this map is updated. so it is not always empty. -- To view, visit https://asterix-gerrit.ics.uci.edu/1322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
