Yingyi Bu has posted comments on this change. Change subject: Remove ICCContext ......................................................................
Patch Set 4: (1 comment) In short, I think the design of context classes are well conceived. Yes, it might not be fully utilized for today's features, but I prefer to keep them as they are, for future extensions. https://asterix-gerrit.ics.uci.edu/#/c/1322/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IClusterControllerService.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/service/IClusterControllerService.java: Line 39: Map<InetAddress, Set<String>> getIpAddressNodeNameMap(); > This interface is to avoid the casting. For (1), I'm more than happy if you can move ClusterControllerContext out of ClusterControllerService. It's easy to do. The absolute code size doesn't vary too much, and I think we should focus on what the right design is. For (2), you're right --- the design is somewhat under utilized, but the design itself is good. Look at the counter example, AqlMetadataProvider. It's not about cast or not, but about separating concerns and extensibility. -- To view, visit https://asterix-gerrit.ics.uci.edu/1322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
