Yingyi Bu has posted comments on this change. Change subject: Remove ICCContext ......................................................................
Patch Set 5: BTW, the method getIpAddressNodeNameMap in ClusterControllerService should be disabled. Here is my proposal. If we want to do the refactoring, we probably should refactor the CC/NC service in a way that we do not remove ICCContext and ServerContext, but factor out more things into the two contexts. In principle, XXXWorks should only be able to see the contexts but not the service, such that they cannot call start() and stop() of the service. In this way, we can simplify the CC/NC service implementations and future extensions by separating out low-level details. -- To view, visit https://asterix-gerrit.ics.uci.edu/1322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
