Yingyi Bu has posted comments on this change. Change subject: Remove ICCContext ......................................................................
Patch Set 5: Removing GetIpAddressNodeNameMapWork.java will introduce a new bug -- the ipAddressNodeNameMap is no longer thread safe. Since workqueue is single threaded, the previous approach is thread safe. RuntimeUtils needs re-implementations (as in the master, not because of this change) since RuntimeUtils.getNodeControllerMap() needs to run on the CC, which shouldn't be necessary. Using IHyracksClientConnection should be able to achieve the same thing. -- To view, visit https://asterix-gerrit.ics.uci.edu/1322 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f6a769741f14e91bcd4b970b4a022c0a453d380 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
