Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1650: fix undefined variable reference resolution. ......................................................................
Patch Set 6: (1 comment) Look good. Just one question on the ParserTestUtils and one more general question: I notice, that many of the changed ASTs are for fuzzyjoins. Is there something specific about those queries that makes a runtime resolution more likely? https://asterix-gerrit.ics.uci.edu/#/c/1408/6/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java: Line 40: String subdir = innerfile.isDirectory() ? path + innerfile.getName() + separator : path; Isn't TestHelper.joinPath a more robust way to join paths than string concatenation? This seems to rely on the fact that "path" ends with a file separator. -- To view, visit https://asterix-gerrit.ics.uci.edu/1408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e4c1b38e53c97380cfb3e2e9b61cdd05fe7002 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
