Yingyi Bu has posted comments on this change.
Change subject: ASTERIXDB-1650: fix undefined variable reference resolution.
......................................................................
Patch Set 7:
Hi Till,
For your question:
"I notice, that many of the changed ASTs are for fuzzyjoins. Is there
something specific about those queries that makes a runtime resolution more
likely?"
There is nothing special in those queries. This change fixed the
application stability issue that exists in the master. The parser test runs in
a *mocked* environment:
-- The mocked metadata provider always returns true for any dataset
existence inquiries;
-- Therefore, previously, in the test, those undefined identifiers are
resolved as datasets. Now, we fixed the resolution order according the
description in ASTERIXDB-1650, and then those identifiers should always be
resolved to field-accesses first if possible, and finally be resolved to
datasets.
Let me know if you have further questions. Thx!
Best,
Yingyi
--
To view, visit https://asterix-gerrit.ics.uci.edu/1408
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24e4c1b38e53c97380cfb3e2e9b61cdd05fe7002
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-Reviewer: Yingyi Bu <[email protected]>
Gerrit-HasComments: No
