Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1650: fix undefined variable reference resolution. ......................................................................
Patch Set 6: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/1408/6/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/sqlpp/ParserTestUtil.java: Line 40: String subdir = innerfile.isDirectory() ? path + innerfile.getName() + separator : path; > Isn't TestHelper.joinPath a more robust way to join paths than string conca Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1408 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I24e4c1b38e53c97380cfb3e2e9b61cdd05fe7002 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
