Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data ......................................................................
Patch Set 6: (12 comments) https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/exceptions/ErrorCode.java: Line 119: public static final int ERROR_PARSER_FACTORY_HIVE_DATA_PARSER_FACTORY_NO_SERDE = 3052; ERROR_PARSER_FACTORY_HIVE_DATA_PARSER_FACTORY_NO_SERDE is not used? Or it should be used but there is a typo somewhere? https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: Line 54: 3002 = Tuple is too large for a frame Can't feed handle large objects? Line 62: 3010 = doesn't support hive data with list of non-primitive types hive -> Hive Line 63: 3011 = Can't get hive type for field of type %1$s hive -> Hive Line 65: 3013 = Can't deserialize hive records with no closed columns hive -> Hive Line 68: 3016 = can't parse null field can't -> Can't Line 69: 3017 = can't parse hive list with null values hive -> Hive Line 104: 3052 = no hive serde provided for hive deserialized records hive -> Hive Line 131: 3079 = Was not able to find a file in the files index Let all messages start with capital letter? https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/dataflow/FeedExceptionHandler.java: Line 65: } catch (Exception exception) { Why not print the stack trace? It's easier for debugging if the stack trace is printed. https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java: Line 36: public boolean continueIngestionPostSoftwareFailure(HyracksDataException e) throws HyracksDataException { > MAJOR SonarQube violation: The method is never used? https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java: Line 52: throw new IllegalArgumentException("no hive serde provided for hive deserialized records"); I'm guessing the configure method is only called at the compiler side. If that's the case, this should be a CompilationException. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
