Yingyi Bu has posted comments on this change. Change subject: Runtime ErrorCode fix in external data ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/CounterTimerTupleForwarder.java: Line 161: LOGGER.log(Level.WARNING, e.getMessage()); Why not print stack trace or log stack trace? Having a stack trace will help a lot for debugging, compared to only having an error message. https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedIntakeOperatorDescriptor.java: Line 125: String message = "Unable to create adapter as class loader not configured for library " + adaptorLibraryName > Remove the hardcoded message. RuntimeDataException exception = new RuntimeDataException(...) LOGGER.severe(exception.getMessage()); throw exception; -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-HasComments: Yes
