Xikui Wang has posted comments on this change. Change subject: Runtime ErrorCode fix in external data ......................................................................
Patch Set 7: The NotImplementedException and IllegalStateException are changed to HyrackDataException and thrown explicitly. Is this the right way to handle them? @Abdullah, there are some comments from Yingyi in last patch which I am not that certain. Could you help me verify? Also there is a Exception check in LocalFSInputStream... I think this patch would not affect that. Could you also verify it? -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
