abdullah alamoudi has posted comments on this change. Change subject: Runtime ErrorCode fix in external data ......................................................................
Patch Set 6: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties File asterixdb/asterix-common/src/main/resources/asx_errormsg/en.properties: Line 54: 3002 = Tuple is too large for a frame > Can't feed handle large objects? Checked the two places where this is used. It will never be thrown because now we expand the frame. We can change the place where they are used to: if (!appender.append(tuple)) { appender.write(writer, true); appender.append(tuple); } Or simply leave it/replace it with illegal state exception! Not sure what the right approach is. Throughts @Yingyi? https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/feed/policy/FeedPolicyEnforcer.java: Line 36: public boolean continueIngestionPostSoftwareFailure(HyracksDataException e) throws HyracksDataException { > The method is never used? That is correct. It is some leftover from the early feed days. we still didn't get to look at exception handling for feeds + policies. Let's leave it for now and once we cleanup this part, we will either use it or remove it. https://asterix-gerrit.ics.uci.edu/#/c/1374/6/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/parser/factory/HiveDataParserFactory.java: Line 52: throw new IllegalArgumentException("no hive serde provided for hive deserialized records"); > I'm guessing the configure method is only called at the compiler side. If I think it should be compilation exception too. -- To view, visit https://asterix-gerrit.ics.uci.edu/1374 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida810a56bf4aef1394879f088a6a5e8f82c60b74 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
