Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 38: (3 comments) Thanks for addressing the comments. Regarding the exception, I put more comments. Basically, the idea behind the new exception handling proposal is that for every exception, we need to provide a code and a message and both are defined in separate files. https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java: Line 421: throw new AlgebricksException(e); I think this should be a CompilationException and it needs to have an error code, too. Line 428: } catch (AsterixException e) { We will not use AsterixException. So, after this patch set: https://asterix-gerrit.ics.uci.edu/#/c/1437/ is merged, we need to change it to CompilationException. For now, you can keep it as it is. Line 429: throw new AlgebricksException(e); I think this should be a CompilationException and it needs to have an error code, too. -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 38 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <[email protected]> Gerrit-Reviewer: Chen Li <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Wenhai Li <[email protected]> Gerrit-HasComments: Yes
