Taewoo Kim has posted comments on this change.
Change subject: Applied the multiway fuzzyjoin based on the prefix-based join
and the selectFuzzyJoin testCases.
......................................................................
Patch Set 38:
(8 comments)
A few more comments:
1. Could you tell me why the following test results are also affected?
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/exists.plan
asterixdb/asterix-app/src/test/resources/optimizerts/results/subquery/not_exists.plan
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping.plan
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpch/q12_shipping_broadcast.plan
2. Other than optimizer tests, have we added a few run-time tests as well?
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/compiler/provider/DefaultRuleSetFactory.java:
Line 54: defaultLogicalRewrites
This line should not be changed. Let's keep it as it is.
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-hybrid.aql
File
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-hybrid.aql:
Line 20: * Description : Multiple fuzzy join on three tables, with a star
join condition.
tables -> datasets
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-selflink.aql
File
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-selflink.aql:
Line 21: * The base table DBLP will fuzzy join with CSX and
propagate the results
table -> dataset
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-simple.aql
File
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-simple.aql:
Line 19: drop dataverse fj-dblp-csx if exists;
Please put a comment here - what this test does.
Line 26: id: int32,
Remove this white space.
Line 34: id: int32,
Remove this white space.
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-star.aql
File
asterixdb/asterix-app/src/test/resources/optimizerts/queries/fj-dblp-csx-star.aql:
Line 21: * The CSX and DBLP tables are used twice and will be
propagated onto
table -> dataset
https://asterix-gerrit.ics.uci.edu/#/c/1076/38/asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-4.1.1/word-jaccard.1.ddl.aql
File
asterixdb/asterix-app/src/test/resources/runtimets/queries/fuzzyjoin/dblp-csx-4.1.1/word-jaccard.1.ddl.aql:
Line 21: * We expect the join to be transformed into an
prefix-based fuzzy join following with a < select.
an -> a
--
To view, visit https://asterix-gerrit.ics.uci.edu/1076
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc
Gerrit-PatchSet: 38
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <[email protected]>
Gerrit-Reviewer: Chen Li <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Wenhai Li <[email protected]>
Gerrit-HasComments: Yes
