Taewoo Kim has posted comments on this change. Change subject: Applied the multiway fuzzyjoin based on the prefix-based join and the selectFuzzyJoin testCases. ......................................................................
Patch Set 38: (7 comments) Sorry, a few more. https://asterix-gerrit.ics.uci.edu/#/c/1076/38/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismUtilities.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/visitors/IsomorphismUtilities.java: Line 81: // Iteratively get all the produced variables from the downstream operators of root. This returns an operator that produced the given PK variable. Right? Please change the description. Line 82: private static ILogicalOperator extractPKProduction(ILogicalOperator root, LogicalVariable pk) extractPKProduction -> getOpThatProducePK, root -> rootOp, pk -> PKvar, Line 92: validate = true; Rather than using validate variable, you can just break here. Please check. Line 96: validate = true; Rather than using validate variable, you can just break here. Please check. Line 107: public static void mergeHomogeneousPK(ILogicalOperator op, List<LogicalVariable> pks) throws AlgebricksException { pks -> PKvars, Line 112: throw new AlgebricksException("Illegal variable production."); Please follow the new exception handling proposal. Line 116: Map<LogicalVariable, LogicalVariable> variableMapping = new HashMap<>(); What's key and value? Can we put a comment? -- To view, visit https://asterix-gerrit.ics.uci.edu/1076 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8736f104905eeda763d39709e002c2b9629278cc Gerrit-PatchSet: 38 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Wenhai Li <lwhaym...@yahoo.com> Gerrit-Reviewer: Chen Li <che...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@yahoo.com> Gerrit-Reviewer: Wenhai Li <lwhaym...@yahoo.com> Gerrit-HasComments: Yes
