Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for pre-distributed jobs ......................................................................
Patch Set 24: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java: PS24, Line 32: DistributedJobStore The prefix "Distributed" is a bit confusing, as 1. jobs in hyracks are executed "distributedly". 2. it could be parsed by a human as distributed JobStore Could you use another name, e.g., "PreDistributed", "Active", etc to avoid confusions for readers? https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java: PS24, Line 487: byte[] acgBytes = null; : if (!predistributed) { : acgBytes = JavaSerializationUtils.serialize(acg); : } use a conditional expression? byte acgBytes = predistributed? null : JavaSerializationUtils.serialize(acg); https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java: PS24, Line 115: finished Can you comment in the code why it is times(4) for getDistributedJobStore? It's not very obvious to me. PS24, Line 118: storeActivityClusterGraph verify the call count of checkDuplicateXXX ? -- To view, visit https://asterix-gerrit.ics.uci.edu/1377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954 Gerrit-PatchSet: 24 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
