Yingyi Bu has posted comments on this change. Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for pre-distributed jobs ......................................................................
Patch Set 24: "In order to use the mockito library to monitor the method calls on this class, the creation of these had to be moved from the constructor to the start() method (since they pass "this"). This forces them to become non-final" I'm not sure how much those members will affect your testing. Let's say, if those members still refer to the non-spied NC/CC instance, your call count verification will still work? Did I miss anything? -- To view, visit https://asterix-gerrit.ics.uci.edu/1377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954 Gerrit-PatchSet: 24 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
