Steven Jacobs has posted comments on this change. Change subject: ASTERIXDB-1747 Implemented full lifecycle capabilities for pre-distributed jobs ......................................................................
Patch Set 24: (4 comments) "I'm not sure how much those members will affect your testing. Let's say, if those members still refer to the non-spied NC/CC instance, your call count verification will still work? Did I miss anything?" The issue is this: The calls that happen to getPreDistributedJobStore() end up coming from the IPC's. If these are assigned in the constructor, the "this" that's passed isn't a mocked class, so those calls don't register as happening in the mocked class which means the call counts stay at 0 (I learned from trying this first). The only way to get the calls to be acknowledged is to pass "this" when "this" refers to the mocked class (in the start() methods). https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/DistributedJobStore.java: PS24, Line 32: DistributedJobStore > The prefix "Distributed" is a bit confusing, as I want to avoid active as this also has specific implications in Asterix. I changed to PreDistributed. https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/executor/JobExecutor.java: PS24, Line 487: byte[] acgBytes = null; : if (!predistributed) { : acgBytes = JavaSerializationUtils.serialize(acg); : } > use a conditional expression? Done https://asterix-gerrit.ics.uci.edu/#/c/1377/24/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/integration/DistributedJobsTest.java: PS24, Line 115: finished > Can you comment in the code why it is times(4) for getDistributedJobStore? Done PS24, Line 118: storeActivityClusterGraph > verify the call count of checkDuplicateXXX ? Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1377 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59c3422d5c1ab7756a6a4685ac527dfe50434954 Gerrit-PatchSet: 24 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Carey <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: Yingyi Bu <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
