>From Ritik Raj <[email protected]>: Attention is currently required from: Murtadha Hubail, Peeyush Gupta. Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 )
Change subject: [ASTERIXDB-3383][RT] Introducing tuple filter to ingestion pipeline ...................................................................... Patch Set 3: (6 comments) Commit Message: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/e6c57d5a_5bb733e0 PS2, Line 7: [NO ISSUE] > ASTERIXDB-3383 Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/50d615b7_06d1d511 PS2, Line 7: OTH > RT Done File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/NoOpLSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/2a3a4ef1_92a79642 PS2, Line 38: true > This should be the other way around. Filter should exclude things. Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/1b1c9255_46113ad3 PS2, Line 33: before > initialize? Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/f1e60b8c_82b8c3ce PS2, Line 33: storagePartitionIdx > It doesn't make much sense to pass this as well as the index > storagePartitionIdx as well as the inde […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/fd506d0c_be439689 PS2, Line 38: int storagePartitionIdx > you won't need this here Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id79607bdada1cd42949cccf43390a90dda092602 Gerrit-Change-Number: 18239 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2024 23:47:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
