>From Murtadha Hubail <[email protected]>: Attention is currently required from: Peeyush Gupta, Ritik Raj. Murtadha Hubail has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 )
Change subject: [ASTERIXDB-3383][RT] Introducing tuple filter to ingestion pipeline ...................................................................... Patch Set 3: Code-Review+2 (5 comments) Patchset: PS3: Feel free to address the comments in another patch. File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/0c8e5726_c771251c PS3, Line 536: // get the Tuple filter callback You really don't need this comment. File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/3764cba8_9d9aec65 PS3, Line 29: Populates the state within the filter callback by fetching the state from the provided "index" : * and mapping it with the storage partition index, which will be utilized for filtering : * the tuple directed to the index "storagePartitionIdx" You should just replace this by "initializes the filter callback" or something generic like that. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/f4668510_d8e7a4bd PS3, Line 36: Filter the received record based on the initialized ingestion state. This should be more generic than this. It isn't really tired to ingestion. You can see other examples using javadocs in the codebase. File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/3e97005a_a09f1916 PS3, Line 27: * The field tuple contains information about the position of the record, meta, and primary key, : * facilitating the extraction of relevant information for filtering purposes. Remove this. It is too specific to one implementation. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id79607bdada1cd42949cccf43390a90dda092602 Gerrit-Change-Number: 18239 Gerrit-PatchSet: 3 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Attention: Peeyush Gupta <[email protected]> Gerrit-Attention: Ritik Raj <[email protected]> Gerrit-Comment-Date: Fri, 19 Apr 2024 21:24:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
