>From Ritik Raj <[email protected]>: Ritik Raj has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 )
Change subject: [ASTERIXDB-3383][RT] Introducing tuple filter to ingestion pipeline ...................................................................... Patch Set 4: (4 comments) File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtil.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/3a2fb8ed_6d460be6 PS3, Line 536: // get the Tuple filter callback > You really don't need this comment. Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallback.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/16f6b802_c41c6ec2 PS3, Line 29: Populates the state within the filter callback by fetching the state from the provided "index" : * and mapping it with the storage partition index, which will be utilized for filtering : * the tuple directed to the index "storagePartitionIdx" > You should just replace this by "initializes the filter callback" or > something generic like that. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/b6155c1a_17315c7a PS3, Line 36: Filter the received record based on the initialized ingestion state. > This should be more generic than this. It isn't really tired to ingestion. […] Done File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMTupleFilterCallbackFactory.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239/comment/672a95f7_59fece52 PS3, Line 27: * The field tuple contains information about the position of the record, meta, and primary key, : * facilitating the extraction of relevant information for filtering purposes. > Remove this. It is too specific to one implementation. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18239 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: Id79607bdada1cd42949cccf43390a90dda092602 Gerrit-Change-Number: 18239 Gerrit-PatchSet: 4 Gerrit-Owner: Ritik Raj <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Peeyush Gupta <[email protected]> Gerrit-Comment-Date: Sun, 21 Apr 2024 19:05:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Murtadha Hubail <[email protected]> Gerrit-MessageType: comment
