>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 )
Change subject: DOC-12137: Add ARRAY_MEDIAN() Function ...................................................................... Patch Set 2: (8 comments) Patchset: PS2: We should highlight somewhere in the "Window Functions" section that median() as a window function supports only PARTITION BY clause, but not ORDER BY or FRAME specification. File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/3c7e4f55_a208360d PS2, Line 185: Gets the median value of the non-null and non-missing numeric items in the given collection. I would say: Gets the median value of the numeric items in the given collection ignoring NULLs, MISSINGs, and non-numeric items. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/e976099d_f828a46a PS2, Line 193: expression 'clause' instead of 'expression'. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/3beb79b8_e77fa95f PS2, Line 197: an `array` or `multiset` of numbers. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/af79e933_d24b0218 PS2, Line 201: non-null and non-missing numbers Maybe simpler to say "numeric items". https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/aa5885e7_21c78904 PS2, Line 203: any non-null and non-missing items "any numeric items". https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/a290bf71_a677a6d0 PS2, Line 204: * any other non-array and non-multiset input value will cause a type error, We actually return "null" similar to array_min(), array_max() and the like. https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/11cb348d_7f9a1738 PS2, Line 205: will cause a type error. "will be ignored". If you prefer, we can actually remove this bullet point because it's already covered above. -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 2 Gerrit-Owner: Simon Dew <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Simon Dew <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2024 13:56:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
