>From Ali Alsuliman <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman, Simon Dew. Ali Alsuliman has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 )
Change subject: DOC-12137: Add ARRAY_MEDIAN() Function ...................................................................... Patch Set 3: (1 comment) File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/e742fb32_2dd832a4 PS2, Line 204: * any other non-array and non-multiset input value will cause a type error, > Done. This doesn't match what it currently says for array_max and array_min. > […] Yes, please. I went through all of them to make sure they are correct. Several are out of sync. For most of them, we stopped throwing an error. Here is what needs to change: * `null` is returned if the input is `null` or `missing` -> 0 is returned * any other non-array and non-multiset input value will cause an error -> 0 is returned if the input is not an array or a multiset array_count(); * any other non-array and non-multiset input value will cause a type error -> `null` is returned if the input is not an array or a multiset * any other non-numeric value in the input collection will cause a type error -> any other non-numeric value in the input collection will be ignored array_avg(); * any other non-array and non-multiset input value will cause a type error -> `null` is returned if the input is not an array or a multiset * any other non-numeric value in the input collection will cause a type error -> any other non-numeric value in the input collection will be ignored array_sum( [1.2, 2.3, 3.4, 0, null, missing] ); * any other non-array and non-multiset input value will cause a type error -> `null` is returned if the input is not an array or a multiset * multiple incomparable items in the input array or multiset will cause a type error -> `null` is returned if there are incomparable items in the input array or multiset array_min( [1.2, 2.3, 3.4] ); array_max( [1.2, 2.3, 3.4, 0, null, missing] ); strict_min(); strict_max(); * any other non-array and non-multiset input value will cause a type error -> `null` is returned if the input is not an array or a multiset array_stddev_samp() array_stddev_pop() array_var_samp() array_var_pop() array_skewness() array_kurtosis() * `null` is returned if the input is `null` or `missing` -> 0 is returned strict_count(); * any other non-array and non-multiset input value will cause a type error -> `null` is returned if the input is not an array or a multiset * any other non-numeric value in the input collection will cause a type error -> 'null' is returned strict_avg(); strict_sum(); -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Dew <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Simon Dew <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2024 18:08:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Comment-In-Reply-To: Simon Dew <[email protected]> Gerrit-MessageType: comment
