>From Simon Dew <[email protected]>: Attention is currently required from: Murtadha Hubail, Ali Alsuliman. Simon Dew has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 )
Change subject: DOC-12137: Add ARRAY_MEDIAN() Function ...................................................................... Patch Set 3: (9 comments) Patchset: PS2: > We should highlight somewhere in the "Window Functions" section that median() > as a window function s […] Done Patchset: PS3: Updates after review of patch set 2 File asterixdb/asterix-doc/src/main/markdown/builtins/9_aggregate_sql.md: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/b49bb0c7_c1e39c10 PS2, Line 185: Gets the median value of the non-null and non-missing numeric items in the given collection. > I would say: […] Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/b7b1d77e_ad38fcd0 PS2, Line 193: expression > 'clause' instead of 'expression'. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/35e2a5c2_c165020f PS2, Line 197: an `array` or `multiset` > of numbers. Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/48b78ee5_f49adc43 PS2, Line 201: non-null and non-missing numbers > Maybe simpler to say "numeric items". Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/c3104bef_3c860cd3 PS2, Line 203: any non-null and non-missing items > "any numeric items". Done https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/fda9d47c_85544725 PS2, Line 204: * any other non-array and non-multiset input value will cause a type error, > We actually return "null" similar to array_min(), array_max() and the like. Done. This doesn't match what it currently says for array_max and array_min. Do you need me to update the other function results? https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251/comment/18bfe5fb_4feb3b3e PS2, Line 205: will cause a type error. > "will be ignored". […] Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18251 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: neo Gerrit-Change-Id: Icb6459ea616244a048ed95757b3a0eb9094ba85a Gerrit-Change-Number: 18251 Gerrit-PatchSet: 3 Gerrit-Owner: Simon Dew <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-CC: Ali Alsuliman <[email protected]> Gerrit-Attention: Murtadha Hubail <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Wed, 24 Apr 2024 16:13:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
