>From Ian Maxon <[email protected]>: Attention is currently required from: Hussain Towaileb, Ali Alsuliman. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373 )
Change subject: [ASTERIXDB-3429][EXT] Configurable CSV escape char ...................................................................... Patch Set 1: Verified+1 Code-Review+1 (1 comment) File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373/comment/b532d515_920c5151 PS1, Line 195: startedQuote = true; this part seems suspicious to me. why do we start quote, before we have determined whether or not it is an escape yet? -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I50bebc4b8b683889855cb5dd048ab27d7c93af76 Gerrit-Change-Number: 18373 Gerrit-PatchSet: 1 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Thu, 13 Jun 2024 16:19:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
