>From Ian Maxon <[email protected]>: Attention is currently required from: Hussain Towaileb, Ali Alsuliman. Ian Maxon has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373 )
Change subject: [ASTERIXDB-3429][EXT] Configurable CSV escape char ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataUtils.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373/comment/9a7cd099_c81a69ca PS1, Line 147: ExternalDataConstants.CSV_ESCAPE > I think this will depend on the format. If it is not CSV, then it should be > ExternalDataConstants. […] ah, yes you are right. for example TSV uses \ (e.g. \t, \r) most of the time. File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/FieldCursorForDelimitedDataParser.java: https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373/comment/3f121b22_63493c26 PS1, Line 69: double > escaped Done -- To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/18373 To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Change-Id: I50bebc4b8b683889855cb5dd048ab27d7c93af76 Gerrit-Change-Number: 18373 Gerrit-PatchSet: 2 Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Ali Alsuliman <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Hussain Towaileb <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-CC: Mehnaz Tabassum Mahin <[email protected]> Gerrit-Attention: Hussain Towaileb <[email protected]> Gerrit-Attention: Ali Alsuliman <[email protected]> Gerrit-Comment-Date: Tue, 18 Jun 2024 07:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Ali Alsuliman <[email protected]> Gerrit-MessageType: comment
